Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #14: define required [[UnderlyingIterators]] internal slot #15

Merged
merged 2 commits into from
Oct 10, 2024
Merged

fixes #14: define required [[UnderlyingIterators]] internal slot #15

merged 2 commits into from
Oct 10, 2024

Conversation

michaelficarra
Copy link
Member

Fixes #14.

@michaelficarra michaelficarra mentioned this pull request Oct 10, 2024
Closed
@bakkot
Copy link
Collaborator

bakkot commented Oct 10, 2024 •
edited
Loading

You don't need to actually use the slot. It's only ever used if .return is called before the first call to .next, but in that case, for this algorithm, no iterables have been opened.

It just needs to be present because .return expects it to be there.

@michaelficarra
Copy link
Member Author

Ah, that's true. Okay I'll simplify.

bakkot
bakkot reviewed Oct 10, 2024
View reviewed changes
spec.emu Outdated Show resolved Hide resolved
@michaelficarra @bakkot
Update spec.emu
5a1b317 
Co-authored-by: Kevin Gibbons <[email protected]>
@michaelficarra michaelficarra merged commit e1dad98 into main Oct 10, 2024
2 checks passed
@michaelficarra michaelficarra deleted the GH-14 branch October 10, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bakkot bakkot bakkot left review comments

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

%IteratorHelperPrototype%.return requires the internal slot?
3 participants
@michaelficarra @bakkot @ljharb