Add support for using TLA to configure libtap/settings #39
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Top level await alters load ordering. For example if you have
./tap.js
:./libtap-setup.js
:In this case
tap.js
was written to run thelibtap-setup.js
steps to completion beforelibtap
is imported. Unfortunately having top level await inlibtap-setup.js
or anything it imports changes the order.libtap
starts loading as soon as the first top level await is hit.With this patch you would make two small changes. You would change
import t from 'libtap'
toimport t from 'libtap/tla'
, then you would add a call tosettings.markAsReady()
after the settings changes are complete.I'm not settled on this approach though it's the best I have right now.