Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assorted fixes #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Assorted fixes #31

wants to merge 1 commit into from

Conversation

dagwieers
Copy link
Contributor

@dagwieers dagwieers commented Jan 10, 2020 •
edited
Loading

This PR includes:

  • Use a oneline GPLv3 license statement
  • Favor Python 3 code over Python 2
  • Expose addon_id to add-ons
  • Avoid a second addon_id lookup
  • Add PYTHON to Makefile to facilitate testing multiple python versions
  • Add tox.ini configuration
  • Test against python 3.5 and python 3.8
  • Use selective imports

@dagwieers dagwieers force-pushed the assorted-changes branch 6 times, most recently from 9ad13df to 25722f7 Compare January 10, 2020 14:53
@dagwieers dagwieers marked this pull request as ready for review January 10, 2020 14:53
@dagwieers
Assorted fixes
f3d1d9e 
This PR includes:
- Use a oneline GPLv3 license statement
- Favor Python 3 code over Python 2
- Expose addon_id to add-ons
- Avoid a second addon_id lookup
- Add PYTHON to Makefile to facilitate testing multiple python versions
- Add tox.ini configuration
- Test against python 3.5 and python 3.8
- Use selective imports
@dagwieers
Copy link
Contributor Author

@tamland Can we get this merged as well? It makes it possible to use the routing module even in the absence of xbmcaddon (great for testing scenarios like the one from #30).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dagwieers