-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid value detection #872
base: main
Are you sure you want to change the base?
Conversation
Cool idea! How do you think it should work alongside custom CSS? You might have a class like |
* Feat: working ignore option * Chore: cleanup && improve: better similarity finding * Chore: more styling and wording changes * Chore: more wording changes..
Hi @adamwathan, I finally had some time to add the ignore feature; The ignored keys get stored in the workspaces settings.json file, just like e.g CSpell. For me this works great! Please take a look again and let me know what you think. Thanks, |
Hey I completely forgot about this pull request but it seems no one has looked at it yet. @thecrypticace could you take a look? |
What if we just inform users that there are custom elements? We don't have to assume that every unknown element is an error. If a project is using Tailwind, I think it's safe to assume that generally Tailwind classes will be used. From my experience, all I need is quick feedback that I have a custom element. This is quite similar to how CSpell is working in VSCode. From here we can think about some extra heuristics or options regarding detection etc. |
Hi there,
I created an addition to the extension that checks for invalid tailwindcss values. I think it could help novice programmers debug their css quicker.
Screenshots:
In code:
In problems:
Quick fixes:
It's currently in mvp state, but if you want we can make it 'production' ready.
If you are not interested, no problem, did this for my own learnings anyways :P
Thanks,
Alpha