-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support of max-width container queries #20
base: main
Are you sure you want to change the base?
Conversation
The @max-[1024px]/container1:underline case requires a regex fix in the default extractor of Tailwind CSS.
…OG.md with the new feature
Great addition! Not sure why this hasn't been approved yet! Tested it and works great, even when adding multiple container queries for a min & max effect. This simple addition has cleaned up my code immensely. auction-card @[45rem]/auctions:@max-4xl/auctions:auction-card--wide Tested it with arbitray values, as well as with base container queries |
Why this hasn't been approved yet ?! |
@adamwathan not sure if it's acceptable practice to tag the core team on PRs, but I feel like this may have gone unnoticed and would be a great addition to the plug-in |
This would help a lot. Congrats on your implementation! 👏🏽 @pbabcsany
|
@adamwathan Can we get this merged in? Without this, hiding columns as a table gets smaller requires somewhat ridiculous classes. |
Any updates on this? |
It is included in the new version of tailwind I believe so this repo will officially be abandoned in favor of the main tailwind repo I believe. I could have read that wrong though, but I'm pretty sure! |
@ConnorMoodyDev In which tailwind version will this be included? I don't see it yet. |
@florianjuengermann I think @ConnorMoodyDev is referring to container, but it's not the same as |
https://tailwindcss.com/blog/tailwindcss-v4-alpha This will be included in V4
|
This PR implements support of max-width container queries using
@max
oratMax
variants.There are two variants because combination of arbitrary container sizes and named containers are not supported by the current default extractor. To support that case the
atMax
variant has been introduced (although the@max
variant would be syntactically better and more aligned with the rest of the module).README.md contains the usage including the edge case which is only supported by
atMax
. Unit tests has been added as well.Thanks guys, you are really doing a good job with Tailwind CSS.