Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk|cli): add Base Sepolia #147

Merged
merged 3 commits into from
Jun 4, 2024
Merged

feat(sdk|cli): add Base Sepolia #147

merged 3 commits into from
Jun 4, 2024

Conversation

dtbuchholz
Copy link
Contributor

Summary

Adds Base Sepolia chain support.

Details

N/A

How it was tested

  • Updated existing tests to include Base.
  • Created a table with the React JS template: here

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@dtbuchholz
docs(sdk): wrap in backticks to fix autgen parsing
a3326f2
@dtbuchholz
feat(sdk|cli): add base chain support
ba9c351 
Adds Base Sepolia chain support. Note the SDK cannot use the getFeeData function since it's an OP chain. This was tested with the react-js template since it'll log errors wrt that method, and if you don't avoid getting the fee data, you can't execute SQL statements because the estimate gas function fails. Successful table created here: https://testnets.tableland.network/api/v1/tables/84532/2
@dtbuchholz
Copy link
Contributor Author

@joewagner this should be a straightforward one! and I'll get this into the Studio thereafter

joewagner
joewagner previously approved these changes Jun 4, 2024
View reviewed changes
Copy link
Contributor

@joewagner joewagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't do any manual qa, but looks good upon read-through

@joewagner joewagner self-requested a review June 4, 2024 18:28
@dtbuchholz dtbuchholz merged commit 1b2fc1d into main Jun 4, 2024
4 checks passed
@dtbuchholz dtbuchholz deleted the dtb/add-base branch June 4, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joewagner joewagner joewagner approved these changes

@carsonfarmer carsonfarmer Awaiting requested review from carsonfarmer carsonfarmer is a code owner

@sanderpick sanderpick Awaiting requested review from sanderpick sanderpick is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtbuchholz @joewagner