Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Arbitrum Network from Goerli to Sepolia #607

Merged
merged 2 commits into from
Nov 15, 2023

Conversation

avichalp
Copy link
Collaborator

@avichalp avichalp commented Nov 14, 2023

Summary

This pull request includes changes to migrate the Arbitrum network from Goerli to Sepolia.

Key changes include:

Update ChainIDs: The ChainID for Arbitrum has been updated from ArbitrumGoerli to ArbitrumSepolia in the chains.go file. The corresponding ChainID number has also been updated.

Update Configurations: The .env_validator.example and config.json files have been updated to reflect the change in the Arbitrum network. The API key and endpoint for Arbitrum have been updated from Goerli to Sepolia.

Update Endpoints: The endpoint URLs for Arbitrum in the chains.go file have been updated to point to the Sepolia network.

Update Contract Address: The contract address for the Arbitrum network in the chains.go file has been updated.

These changes ensure that the application is now interacting with the Sepolia network for Arbitrum instead of Goerli.

  • Are changes backward compatible with existing SDKs, or is there a plan to manage it correctly?
  • Are changes covered by existing tests, or were new tests included?
  • Are code changes optimized for future code readers, commenting on problematic areas to understand (if any)?
  • Future-self question: Did you avoid unjustified/unnecessary complexity to achieve the goal?
  • Add required ENV vars

NOTE: Doesn't add the healthbot config since we have stopped using healthbot on optimism and arbitrum

@avichalp avichalp marked this pull request as ready for review November 14, 2023 11:37
Copy link
Member

@sanderpick sanderpick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@avichalp avichalp merged commit 6635b0d into main Nov 15, 2023
5 checks passed
@avichalp avichalp deleted the avichalp/migrate-arbitrum branch November 15, 2023 19:30
@avichalp avichalp mentioned this pull request Nov 16, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants