Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add goerli back #604

Merged
merged 2 commits into from
Aug 29, 2023
Merged

add goerli back #604

merged 2 commits into from
Aug 29, 2023

Conversation

avichalp
Copy link
Collaborator

@avichalp avichalp commented Aug 29, 2023

Adding goerli back in the testnet. It turns out that some people are still using it in hackathons since it is still functional till the end of the year.

  • Are changes backward compatible with existing SDKs, or is there a plan to manage it correctly?
  • Are changes covered by existing tests, or were new tests included?
  • Are code changes optimized for future code readers, commenting on problematic areas to understand (if any)?
  • Future-self question: Did you avoid unjustified/unnecessary complexity to achieve the goal?

Signed-off-by: avichalp <[email protected]>
Signed-off-by: avichalp <[email protected]>
@avichalp avichalp marked this pull request as ready for review August 29, 2023 16:08
@avichalp avichalp changed the title Avichalp/add goerli back add goerli back Aug 29, 2023
dtbuchholz
dtbuchholz previously approved these changes Aug 29, 2023
@avichalp avichalp changed the base branch from staging to main August 29, 2023 16:34
@avichalp avichalp dismissed dtbuchholz’s stale review August 29, 2023 16:34

The base branch was changed.

@avichalp avichalp merged commit 59c2eee into main Aug 29, 2023
5 checks passed
@avichalp avichalp deleted the avichalp/add-goerli-back branch August 29, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants