Apply WASI support patch against ICU source tree #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33 tasks
|
Hi @kateinoigakukun thanks for the patch! We recently upgraded our ICU to 74 and I'll reapply your patch on top of 74 |
The original patch is still under review in the upstream ICU project, but it is needed to unblock the swift-foundation build on WebAssembly. See unicode-org/icu#3067
`U_TIMEZONE` must not be defined and dynamic loading features must be disabled for WASI target.
kateinoigakukun
force-pushed
the
yt/wasi-icu-patch
branch
from
2deca9f
to
7a2d6bd
Compare
|
Reapplied my patch on the top of the latest main branch :) |
|
Confirmed this change does not break other platform builds swiftlang/swift-foundation#823 |
MaxDesiatov
approved these changes
Aug 5, 2024
|
Integration test to SwiftCorelibsFoundation: swiftlang/swift-corelibs-foundation#5040 |
|
SwiftCorelibsFoundation and SwiftFoundation integration tests both passed! Merging now... |
iCharlesHu
pushed a commit
to iCharlesHu/swift-foundation-icu
that referenced
this pull request
Aug 6, 2024
* Cherry-pick "ICU-22838 Add WebAssembly/WASI cross-compilation support" The original patch is still under review in the upstream ICU project, but it is needed to unblock the swift-foundation build on WebAssembly. See unicode-org/icu#3067 * [Build] Update compile definitions for WASI target `U_TIMEZONE` must not be defined and dynamic loading features must be disabled for WASI target.
|
Thanks! |
iCharlesHu
added a commit
that referenced
this pull request
Aug 7, 2024
* Cherry-pick "ICU-22838 Add WebAssembly/WASI cross-compilation support" The original patch is still under review in the upstream ICU project, but it is needed to unblock the swift-foundation build on WebAssembly. See unicode-org/icu#3067 * [Build] Update compile definitions for WASI target `U_TIMEZONE` must not be defined and dynamic loading features must be disabled for WASI target. Co-authored-by: Yuta Saito <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
467631d cherry-picks ICU-22838 Add WebAssembly/WASI cross-compilation support
The original patch is still under review in the upstream ICU project, but it is needed to unblock the swift-foundation build on WebAssembly.
And also adjust CMakeLists.txt and Package.swift to disable timezone and dynamic loading features.