make sure iiif drag and drop has aria-label #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
reviewed
Nov 1, 2024
app/helpers/application_helper.rb
Outdated
| link_url = format Settings.iiif_dnd_base_url, query: { manifest: manifest }.to_query | ||
| link_to link_url, class: 'iiif-dnd float-right', data: { turbolinks: false } do | ||
| link_to link_url, class: 'iiif-dnd float-right', data: { turbolinks: false }, | ||
| aria: { label: document['title_display'] } do |
There was a problem hiding this comment.
Shouldn't this be something like "Drag to a IIIF viewer to open "#{document['title_display']}"" ?
There was a problem hiding this comment.
The ticket indicates no. I am assuming it is because the alt text indicates it is drag and drop?
<div class="col-2 col-md-1">
<a class="iiif-dnd float-right" data-turbolinks="false" href=..." aria-label=" Cambridge, Corpus Christi College, MS 002I: The Bury Bible">
<img alt="IIIF Drag-n-drop" src="..." width="30">
</a>
</div>
There was a problem hiding this comment.
@jcoyne I talked with Alan. We have updated the aria label to include drag-n-drop and made the alt text empty.
dnoneill
force-pushed
the
2483-iiif-link
branch
from
0731dbc
to
307485c
Compare
jcoyne
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #2483