source_remove warnings

[ayushnawal]

Fixes #9

[quozl]

Yes, that will fix it.

Also needs GObject to GLib conversion of the timeout_add and source_remove functions.

It is unusual code and has another small fault; the turtle dance animation stutters because a new timeout is scheduled at the time the previous timeout is finishing. Each time there is a small delay, it grows. You'll see how the call to timeout_add happens inside the function. The function also does not explicitly return True or False as it should, instead just an ordinary return, which has the effect of False. It is more correct to use a repeating timeout, that way the function is more likely to be called some multiple of 250ms after the first call.

[ayushnawal]

Thanks. already made a pull request for GObject to GLib with a flake8 pr.

It is unusual code and has another small fault; the turtle dance animation stutters because a new timeout is scheduled at the time the previous timeout is finishing. Each time there is a small delay, it grows. You'll see how the call to timeout_add happens inside the function. The function also does not explicitly return True or False as it should, instead just an ordinary return, which has the effect of False. It is more correct to use a repeating timeout, that way the function is more likely to be called some multiple of 250ms after the first call.

trying to fix the stuttering and delay, will update you

[quozl]

Reviewed 12b1960 again. It misses the mark. Another reason may be when _happy_turtle_dance returns early. Thus self._timeout_id would still be set but GLib would not have the event source registered.

[chimosky]

Closing as this has been fixed in 843e726.