Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refractor: prettified the code in js folder #2881

Closed
wants to merge 1 commit into from
Closed

refractor: prettified the code in js folder #2881

wants to merge 1 commit into from

Conversation

abhishekkumar08
Copy link
Contributor

@abhishekkumar08 abhishekkumar08 commented Mar 11, 2021 •
edited
Loading

Refrence: #2609

daksh4469
daksh4469 reviewed Mar 11, 2021
View reviewed changes
Copy link
Member

@daksh4469 daksh4469 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that you add the global variables and their locations where they are missing so as to get rid of the linting errors.

@abhishekkumar08
Copy link
Contributor Author

I suggest that you add the global variables and their locations where they are missing so as to get rid of the linting errors.

yeah okay I would do it part by part as there are many liniting errors(2K+) not cramming up all in a single PR.

@abhishekkumar08
Copy link
Contributor Author

@meganindya Have a look. Thanks

@daksh4469
Copy link
Member

There is already a PR pertaining to js/blocks.js file: #2833.

@meganindya
Copy link
Member

Are these all automated changes?

@abhishekkumar08
Copy link
Contributor Author

Yes, all by auto formatting of prettier

@walterbender
Copy link
Member

This is obsolete due to recent refactoring.

@abhishekkumar08 abhishekkumar08 deleted the ref/prettify branch May 23, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daksh4469 daksh4469 daksh4469 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abhishekkumar08 @daksh4469 @meganindya @walterbender