Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

js/activity.js : prettify, linting and jsdocs #2820

Closed
wants to merge 2 commits into from
Closed

js/activity.js : prettify, linting and jsdocs #2820

wants to merge 2 commits into from

Conversation

abhishekkumar08
Copy link
Contributor

Reference #2630, #2609

@abhishekkumar08 abhishekkumar08 changed the title added all the global variables js/activity.js : prettify, linting and jsdocs Feb 7, 2021
@abhishekkumar08
Copy link
Contributor Author

@meganindya Please observe this d387b8f even after adding the global variable, it shows this error
image
How to resolve this?

@meganindya
Copy link
Member

This file is in dangerously bad shape. And, it does a little too much work. This can't be fixed this way. I'll work on it.

@meganindya meganindya closed this Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abhishekkumar08 @meganindya