Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: missing exit wheel in piemenus of temperament, invert and some other blocks #2794

Merged
merged 4 commits into from
Feb 1, 2021

Conversation

ksraj123
Copy link
Member

Reference #2609, #2630, #2767

This PR does the following

  • fixes the no exit wheel in piemenu bug for piemenus in invert, temperament and several other blocks
  • fixes linting issues and prettifies code in js/piemenu.js

Details

Exit wheel in some piemenus of some blocks are missing even though there is space for it. Once the problematic piemenus are opened they could only be closed by clicking on the already selected item again which is not intuitive. This leads to bad user experience as and inconsistency in the user interface as the exit wheel is present in other piemenus.

Before

  • Temperament

temprament_missing_exit_wheel

  • Invert

invert_missing_exit_wheel

Same issue is present in piemenus of a few other blocks as well.

After

  • Temperament

after_temprament_missing_exit_wheel

  • Invert

after_invert_missing_exit_wheel

Copy link
Member

@meganindya meganindya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Just add a .style.cursor = pointer for all the × buttons.

@ksraj123
Copy link
Member Author

ksraj123 commented Feb 1, 2021

@meganindya Apparently this issue was present in almost all of of the pie menus across all blocks.

The blank space next to the x button has pointer but not the x button, ideally the blank space navItem should be disabled.

For exit wheels which had multiple clickable navItems like the number wheel, the selected navItem did not had the cursor even through for our use case the same could be clicked again. So ideally, all clickable navItems should have pointer as the cursor at all times.

multiple clickable items in exit menu number

These issues have been fixed.

@meganindya
Copy link
Member

Yeah. These inconsistencies have existed all along. Somehow, haven't gotten along to fixing those,

@meganindya meganindya merged commit 9e8bc84 into sugarlabs:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants