Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help.js port to ES6 #2676

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Help.js port to ES6 #2676

merged 1 commit into from
Dec 1, 2020

Conversation

ricknjacky
Copy link
Member

In continuation of #2656

and part of fix as proposed in #2609
js/widgets/help.js is now completely cleaned up.

@ricknjacky
Copy link
Member Author

Screenshot (404)
Although the file is ported to ES6 syntax, the linting for some part of the code seems erratic.

This is in reference to conversation thread on #2609
Where @walterbender suggested that

if (
foo &&
bar
) {

is a particularly annoying one.

and

I'd prefer:

if (foo &&
bar) {

So, should I change this file for the same?

@ricknjacky
Copy link
Member Author

ricknjacky commented Dec 1, 2020

PS:- I am addressing the way let label is declared and not the if statement

@meganindya
Copy link
Member

Linting and formatting are different things for the most part. Not really bothering about that on this codebase anymore. There are thousands of issues re those.

Copy link
Member

@meganindya meganindya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@meganindya meganindya merged commit e4c0153 into sugarlabs:master Dec 1, 2020
@ricknjacky ricknjacky deleted the helpCleanup branch December 1, 2020 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants