-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GSoC21: idea for Human Interface Guidelines Redesign #114
Conversation
How many of the activities would be considered as completion? |
The Fructose set along with |
I agree, it would be a good start. How to detect and handle activities that have not been converted? |
I would put forward a suggestion of adding IconColor = True to We could then add a commit to Sugar Shell to set the color of the icons which have In pseudo code if activity_info.is_color:
# do not set color to the activity icon
# as the activity has been ported to multi colors
# we should use the icon as is
doNothingFunction()
else:
# the activity did not set IconColor = True
# this icon is an grey-white and follows the old Human Interface Guidelines
# temporarily, we should set the icon to colorful based on the user selected color theme
setActivityIconAsActive()
if activity_is_used:
# add the badge for both types of icons
addBadge() Let me know if this explanation was okay. I am not sure if I could convey my idea properly 😄 |
Or could we detect from the SVG or rendered pixmap that there are no colours other than black and white, and then assign two of the standard Sugar colours based on a hash of the bundle id? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can consider adding this to Project Task? It would help the student better understand the expected deliverables for the project.
@srevinsaju asked
Not yet. See the timeline. Approximate sequence is;
|
@quozl said
Thanks for the reply. @JuiP said
I would not add that yet. I will add that after #118 has been decided. I am interested to see the student who is willing to do the port to GTK4 to implement the badges for the activities, as the port and the badges feature would otherwise conflict. If #118 is approved, I would prefer to remove the badge feature from #114 and increase the number of activities from Fructose set to something more. |
Thanks for progressing this. Deadline is Friday, Feb 19th at 1900 UTC. |
Thanks, updated the PR. Kindly review |
Reviewed. I think it would be helpful for a student to know that the reason for monochrome icons and high contrasting colour choices was to support reflective displays that cannot show colour. In turn that was because backlights could not be made bright enough for use in high ambient light, without risking large amounts of incidental heat. Since then backlights are more efficient (less heat) and much brighter (in nits). Now that the reflective display technology has all but been abandoned, the requirement is removed, and so Sugar can go for a UI design that is more colourful. |
@srevinsaju any other thing you want to add to this besides what @quozl mentioned above? |
@chimosky No, nothing else. |
Adapted from https://github.com/sugarlabs/GSoC/pull/114\#issuecomment-779464499 Co-authored-by: James Cameron <[email protected]>
I approve. @JuiP as org admin, please review. |
reviewed; looks good to go. |
Adapted from https://github.com/sugarlabs/GSoC/pull/114\#issuecomment-779464499 Co-authored-by: James Cameron <[email protected]>
Rebased. |
Thanks! Merged 😄 |
Closes #112
This is a modified version of https://github.com/sugarlabs/GSoC/blob/master/Ideas-2020.md#colored-desktop-and-activity-icons, added in eaa46b1 by @walterbender. Have made a few small improvements like considering the Sugar UI / UX along with icons and suggested a few optional tasks like finishing the left over design-based pull requests on
sugarlabs/sugar