Add explicit attributes for fields in resources, and rbis for resources #1490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helenye-stripe
force-pushed
the
helenye-beta-fields
branch
from
ce30eab
to
b1df5e1
Compare
helenye-stripe
force-pushed
the
helenye-beta-fields
branch
from
b1df5e1
to
853ccc6
Compare
helenye-stripe
changed the title
helenye-stripe
force-pushed
the
helenye-beta-fields
branch
from
8d598c8
to
8fb9b42
Compare
xavdid-stripe
approved these changes
Nov 20, 2024
| sig { returns(T.nilable(Integer)) } | ||
| attr_reader :void_at | ||
| end | ||
| sig { returns(Integer) } |
There was a problem hiding this comment.
Not that anyone is really reading these, but they'd be a little more legible with the comment first, then sign, then attr, then a line break:
# Change to a FinancialAccount's balance
sig { returns(BalanceImpact) }
attr_reader :balance_impact
# Change to a FinancialAccount's balance
sig { returns(BalanceImpact) }
attr_reader :balance_impactAssuming that ordering plays nicely with hovering in VScode. Either way, a line break might be nice (but that can be in a later PR, not important to regenerate this for that)
| # The last four digits of the token. | ||
| attr_reader :last4 | ||
| # Has the value `true` if the object exists in live mode or the value `false` if the object exists in test mode. | ||
| attr_reader :livemode |
There was a problem hiding this comment.
line breaks would be nice in here as well, IMO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
This is the first step in #1479 - this adds explicit attributes for fields in resources, and adds RBIs with type annotations for them. This is not yet ready for use as it does not define any methods, so I have not included the RBIs in the gemspec.
What?
I recommend reviewing this mostly through the codegen PR, as this is almost entirely generated changes.
Important notes:
lib/stripe/resources/amount.rbandrbi/stripe/resources/amount.rbibecause it is a type used in V2.StripeObject.add_accessors(lib/stripe/stripe_object.rb) to appropriately set instance variables upon creation..rubocop.ymlto ignore variable numbers, since we have field names in various conventions in the API.