Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Bacs to a ConfirmationDefinition type #9688

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

samer-stripe
Copy link
Collaborator

@samer-stripe samer-stripe commented Nov 21, 2024

Summary

Move Bacs to a ConfirmationDefinition type.

Motivation

Helps move to our goal of making DefaultConfirmationHandler injectable.

Testing

  • Added tests
  • Modified tests
  • Manually verified

@samer-stripe samer-stripe added the embedded-confirmation Related to Embedded project in terms of confirmation work label Nov 21, 2024
Copy link
Contributor

github-actions bot commented Nov 21, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed          │         uncompressed         
          ├───────────┬───────────┬──────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff │ old       │ new       │ diff 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │  0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │  0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │  0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │  0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │  0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │  0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.2 KiB │  90.2 KiB │ -3 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼──────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ -3 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19966 │ 19966 │ 0 (+0 -0) 
   types │  6188 │  6188 │ 0 (+0 -0) 
 classes │  4979 │  4979 │ 0 (+0 -0) 
 methods │ 29759 │ 29759 │ 0 (+0 -0) 
  fields │ 17526 │ 17526 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0
APK
   compressed    │  uncompressed   │                        
──────────┬──────┼──────────┬──────┤                        
 size     │ diff │ size     │ diff │ path                   
──────────┼──────┼──────────┼──────┼────────────────────────
 25.3 KiB │ -5 B │ 62.8 KiB │  0 B │ ∆ META-INF/MANIFEST.MF 
  1.2 KiB │ +2 B │  1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA    
──────────┼──────┼──────────┼──────┼────────────────────────
 26.5 KiB │ -3 B │ 64.1 KiB │  0 B │ (total)

Base automatically changed from samer/confirmation-definition-result to master November 21, 2024 16:00
@samer-stripe samer-stripe force-pushed the samer/move-bacs-to-confirmation-definition branch from d4e3651 to 7904281 Compare November 21, 2024 16:01
@samer-stripe samer-stripe marked this pull request as ready for review November 21, 2024 16:40
@samer-stripe samer-stripe requested review from a team as code owners November 21, 2024 16:40
@samer-stripe samer-stripe force-pushed the samer/move-bacs-to-confirmation-definition branch from 4b5e1d6 to e3f6e31 Compare November 21, 2024 21:03
@@ -33,6 +31,8 @@ internal fun <
onResult = {}
)

awaitNextRegisteredLauncher()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an assertThat(...).isNotNull() here?

@samer-stripe samer-stripe force-pushed the samer/move-bacs-to-confirmation-definition branch from 5fec5b2 to 8e8a43c Compare November 21, 2024 22:18
@samer-stripe samer-stripe enabled auto-merge (squash) November 21, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embedded-confirmation Related to Embedded project in terms of confirmation work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants