-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Bacs
to a ConfirmationDefinition
type
#9688
Open
samer-stripe
wants to merge
2
commits into
master
Choose a base branch
from
samer/move-bacs-to-confirmation-definition
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samer-stripe
added
the
embedded-confirmation
Related to Embedded project in terms of confirmation work
label
Nov 21, 2024
Diffuse output:
APK
|
Base automatically changed from
samer/confirmation-definition-result
to
master
November 21, 2024 16:00
samer-stripe
force-pushed
the
samer/move-bacs-to-confirmation-definition
branch
from
November 21, 2024 16:01
d4e3651
to
7904281
Compare
.../main/java/com/stripe/android/paymentelement/confirmation/bacs/BacsConfirmationDefinition.kt
Show resolved
Hide resolved
...t/java/com/stripe/android/paymentelement/confirmation/bacs/BacsConfirmationDefinitionTest.kt
Show resolved
Hide resolved
...t/java/com/stripe/android/paymentelement/confirmation/bacs/BacsConfirmationDefinitionTest.kt
Outdated
Show resolved
Hide resolved
samer-stripe
force-pushed
the
samer/move-bacs-to-confirmation-definition
branch
from
November 21, 2024 18:39
53b7001
to
4b5e1d6
Compare
paymentsheet/src/test/java/com/stripe/android/utils/DummyActivityResultCaller.kt
Show resolved
Hide resolved
samer-stripe
force-pushed
the
samer/move-bacs-to-confirmation-definition
branch
from
November 21, 2024 21:03
4b5e1d6
to
e3f6e31
Compare
jaynewstrom-stripe
previously approved these changes
Nov 21, 2024
samer-stripe
force-pushed
the
samer/move-bacs-to-confirmation-definition
branch
from
November 21, 2024 21:32
e3f6e31
to
5fec5b2
Compare
@@ -33,6 +31,8 @@ internal fun < | |||
onResult = {} | |||
) | |||
|
|||
awaitNextRegisteredLauncher() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an assertThat(...).isNotNull() here?
samer-stripe
force-pushed
the
samer/move-bacs-to-confirmation-definition
branch
from
November 21, 2024 22:18
5fec5b2
to
8e8a43c
Compare
jaynewstrom-stripe
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Move
Bacs
to aConfirmationDefinition
type.Motivation
Helps move to our goal of making
DefaultConfirmationHandler
injectable.Testing