Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inject ConfirmationHandler into FlowController #9651

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samer-stripe
Copy link
Collaborator

Summary

Inject ConfirmationHandler into FlowController

Motivation

Allows for injecting a custom implementation of ConfirmationHandler if needed.

Testing

  • Added tests
  • Modified tests
  • Manually verified

* stripeAccountId after creating a [DefaultFlowController].
*/
lazyPaymentConfiguration: Provider<PaymentConfiguration>,
private val confirmationHandler: ConfirmationHandler,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DefaultFlowController is a special case in which we can inject the ConfirmationHandler directly since we create the FlowControllerViewModel first.

Copy link
Contributor

github-actions bot commented Nov 18, 2024

Diffuse output:

OLD: identity-example-release-base.apk (signature: V1, V2)
NEW: identity-example-release-pr.apk (signature: V1, V2)

          │          compressed           │         uncompressed         
          ├───────────┬───────────┬───────┼───────────┬───────────┬──────
 APK      │ old       │ new       │ diff  │ old       │ new       │ diff 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
      dex │     2 MiB │     2 MiB │   0 B │   4.1 MiB │   4.1 MiB │  0 B 
     arsc │     1 MiB │     1 MiB │   0 B │     1 MiB │     1 MiB │  0 B 
 manifest │   2.3 KiB │   2.3 KiB │   0 B │     8 KiB │     8 KiB │  0 B 
      res │ 301.8 KiB │ 301.8 KiB │   0 B │ 455.5 KiB │ 455.5 KiB │  0 B 
   native │   6.2 MiB │   6.2 MiB │   0 B │  15.8 MiB │  15.8 MiB │  0 B 
    asset │   7.1 KiB │   7.1 KiB │   0 B │   6.9 KiB │   6.9 KiB │  0 B 
    other │  90.2 KiB │  90.2 KiB │ +14 B │ 170.3 KiB │ 170.3 KiB │  0 B 
──────────┼───────────┼───────────┼───────┼───────────┼───────────┼──────
    total │   9.6 MiB │   9.6 MiB │ +14 B │  21.5 MiB │  21.5 MiB │  0 B 

 DEX     │ old   │ new   │ diff      
─────────┼───────┼───────┼───────────
   files │     1 │     1 │ 0         
 strings │ 19966 │ 19966 │ 0 (+0 -0) 
   types │  6188 │  6188 │ 0 (+0 -0) 
 classes │  4979 │  4979 │ 0 (+0 -0) 
 methods │ 29759 │ 29759 │ 0 (+0 -0) 
  fields │ 17526 │ 17526 │ 0 (+0 -0) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  164 │  164 │  0   
 entries │ 3622 │ 3622 │  0
APK
    compressed    │   uncompressed   │                                           
──────────┬───────┼───────────┬──────┤                                           
 size     │ diff  │ size      │ diff │ path                                      
──────────┼───────┼───────────┼──────┼───────────────────────────────────────────
 25.3 KiB │  +6 B │  62.8 KiB │  0 B │ ∆ META-INF/MANIFEST.MF                    
 28.5 KiB │  +5 B │  62.9 KiB │  0 B │ ∆ META-INF/CERT.SF                        
  1.2 KiB │  +2 B │   1.2 KiB │  0 B │ ∆ META-INF/CERT.RSA                       
    272 B │  +1 B │     120 B │  0 B │ ∆ META-INF/version-control-info.textproto 
──────────┼───────┼───────────┼──────┼───────────────────────────────────────────
 55.2 KiB │ +14 B │ 127.1 KiB │  0 B │ (total)

@samer-stripe samer-stripe force-pushed the samer/inject-handler-into-flow-controller branch 2 times, most recently from 5cecfd1 to 188ae71 Compare November 18, 2024 18:45
@samer-stripe samer-stripe force-pushed the samer/inject-handler-into-flow-controller branch from 188ae71 to 2c615dd Compare November 18, 2024 18:58
statusBarColor = statusBarColor,
) as T
}
}
Copy link
Collaborator Author

@samer-stripe samer-stripe Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't been able to find a good way to not inject this through the view model when creating the ConfirmationHandler. I haven't been a fan of the way we fetch the status bar color to handle a small web view case. I'm going to look into seeing if we should remove this or look for a better way of retrieving the status bar color.

@@ -29,7 +28,6 @@ internal class PaymentOptionContract :
internal data class Args(
val state: PaymentSheetState.Full,
val configuration: PaymentSheet.Configuration,
@ColorInt val statusBarColor: Int?,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was not being used by the PaymentOptionActivity.

@samer-stripe samer-stripe marked this pull request as ready for review November 18, 2024 19:03
@samer-stripe samer-stripe requested review from a team as code owners November 18, 2024 19:03
@samer-stripe samer-stripe enabled auto-merge (squash) November 18, 2024 19:39
@samer-stripe samer-stripe added the embedded-confirmation Related to Embedded project in terms of confirmation work label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
embedded-confirmation Related to Embedded project in terms of confirmation work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants