chore: Make "params" argument optional in getter methods #836
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small (backward-compatible) change to the
.getStory
(et al) methods to make the second argument (params) optional. So that you can simplify your code in the following way:How to test this PR
client.getAll
,client.get
,client.getStories
orclient.getStory
.params
argument.What is the new behavior?
There is no Typescript or runtime error when you defer to the client defaults (omit the
params
argument) when calling the Storyblok client's getter methods.