-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pull languages cmd #129
Conversation
…ure/pull-languages-cmd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding some code comments, proceeding to manual testing!
@alvarosabu I manually tested and checked everything 🚀 One thing, the steps you provided mention that I should have |
Awesome, thanks for testing it. Thats weird. My JSON looks like this:
@edodusi Which space are you using? Send me via Slack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Hi, this is the new implementation of the
pull-components
command for the renovated version of the CLI.How to test this PR
295017
or295018
pnpm install
pnpm run dev pull-languages --space <SPACE_ID>
Testing checklist
languages.295017.json
file on the root containing an object"default_lang_name": "en",
if configured on the spacePlease provide the space as argument --space YOUR_SPACE_ID.