Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(hardwaretimer): avoid glitch when PWM configuration changed #2572

Merged
merged 4 commits into from
Nov 21, 2024
Merged

fix(hardwaretimer): avoid glitch when PWM configuration changed #2572

merged 4 commits into from
Nov 21, 2024

Commits on Nov 20, 2024

  1. chore(hardwaretimer): harden get API using uint32_t 

    As all get API's use error handler if an error occur,
then no need to use int as return type.
Moreover, all HAL API uses uint32_t
for those value. This avoid cast issue.

Signed-off-by: Frederic Pillon <[email protected]>
    @fpistm
    fpistm committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    796cbc2 View commit details
    Browse the repository at this point in the history

  2. chore(hardwaretimer): rename TIMER_DISABLED to TIMER_OUTPUT_DISABLED 

    to avoid confusion.

Signed-off-by: Frederic Pillon <[email protected]>
    @fpistm
    fpistm committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    29f0f68 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. fix(hardwaretimer): resume depending of channels mode 

    Allow to properly set handle state.
Start TIM base only if required.

Signed-off-by: Frederic Pillon <[email protected]>
    @fpistm
    fpistm committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    1df53a4 View commit details
    Browse the repository at this point in the history

  2. fix(hardwaretimer): avoid glitch when PWM configuration changed 

    Fixes stm32duino#2575.

Note that the issue is that TIM_OCx_SetConfig() disable
in unconditionally the N state output (TIM_CCER_CCxNE).

Signed-off-by: Frederic Pillon <[email protected]>
    @fpistm
    fpistm committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    6c30d95 View commit details
    Browse the repository at this point in the history