Fix multiple race conditions and error in module inputs #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before passing it into the module's evaluation context we need to evaluate the values first within the parent's evaluation context before sending it to the child goroutine and child conductor because the child evaluation context is independent of the parent's, and it is possible that the particular value may not exist in child.
…conditions to srevinsaju/go-getter, switch global TempDir to conductor.TempDir
srevinsaju
force-pushed
the
fix/module-fix-evalcontext
branch
from
5ccf1ef
to
6a3635b
Compare
Codecov Report
@@ Coverage Diff @@
## v2 #53 +/- ##
==========================================
+ Coverage 62.71% 62.76% +0.05%
==========================================
Files 109 103 -6
Lines 6646 6674 +28
==========================================
+ Hits 4168 4189 +21
- Misses 2206 2214 +8
+ Partials 272 271 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.