Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data.env): fall back to empty string when default is unspecified #30

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

srevinsaju
Copy link
Owner

@srevinsaju srevinsaju commented Aug 6, 2023

Fixes #23

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Merging #30 (05d5b3a) into v1 (1e5cd04) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##               v1      #30      +/-   ##
==========================================
+ Coverage   69.71%   69.74%   +0.02%     
==========================================
  Files          60       60              
  Lines        4237     4241       +4     
==========================================
+ Hits         2954     2958       +4     
  Misses       1107     1107              
  Partials      176      176              
Files Changed Coverage Δ
pkg/blocks/data/env.go 86.11% <100.00%> (+0.81%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@srevinsaju srevinsaju force-pushed the fix/srevin/error-on-empty-default branch from bd8c452 to 05d5b3a Compare August 6, 2023 13:52
@srevinsaju srevinsaju merged commit 45377c9 into v1 Aug 6, 2023
6 checks passed
@srevinsaju srevinsaju deleted the fix/srevin/error-on-empty-default branch August 10, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

data env blocks without default throw an error
1 participant