Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TaskDecorator support for scheduled tasks #43190

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nosan
Copy link
Contributor

@nosan nosan commented Nov 15, 2024

gh-43173

I also marked the existing ThreadPoolTaskSchedulerBuilder constructor with the @Deprecated annotation, as I believe the public modifier was added unintentionally.

I set the version to since 3.5.0, but if possible, could this be merged into 3.4.0 instead? Of course, if you have time.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 15, 2024
@snicoll
Copy link
Member

snicoll commented Nov 16, 2024

Thanks @nosan. We're post RC now so we won't merge additional enhancements.

@snicoll snicoll added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 16, 2024
@snicoll snicoll added this to the 3.5.x milestone Nov 16, 2024
@snicoll snicoll self-assigned this Nov 18, 2024
@snicoll
Copy link
Member

snicoll commented Nov 18, 2024

This PR has been reviewed and is ready to go once we branch. @nosan please disregard the conflict, I changed something on main on purpose and rebased in my polish of this PR.

snicoll pushed a commit to snicoll/spring-boot that referenced this pull request Nov 18, 2024
snicoll added a commit to snicoll/spring-boot that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants