Refactor/Make ZipkinHttpClientSender the default BytesMessageSender #43085
+81
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nderConfiguration` import order to set default sender.
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switch the
@Importorder, and switch the order ofHttpClientSenderConfiguration.classandUrlConnectionSenderConfiguration.class, also adjust the declaration order in fileZipkinConfigurations.javaAnd in order to pass theZipkinConfigurationsSenderConfigurationTests.java, I try to adapt the filter order andtest methodname.Related Issue
Fixed #42589
Type of Change
Checklist
Screenshots
Additional Notes
I switch the
@Importorder to makeZipkinHttpClientSenderto be the defaultBytesMessageSenderimplement🥳, also adapt test fileZipkinConfigurationsSenderConfigurationTeststo be passed which is mentioned in #42589 (comment). And if this PR is ready to merge, could u plz assign #43047, #43048 to me🥺, I'll be glad to do so. If there's anything need to be done, plz comment🥰. Btw, this PR need to be merged to 3.5.x branch, but this branch doesn't exist, so plz create a new one as soon as possible🤩.