JacksonAutoConfiguration should retain modules registered in Jackson2ObjectMapperBuilderCustomizer with higher precedence rather than overwriting them #42836
+25
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nosan
changed the title
spring-projects-issues
added
the
status: waiting-for-triage
…ObjectMapperBuilderCustomizer with higher precedence, rather than overwriting them
mhalbritter
added
type: enhancement
snicoll
pushed a commit
to snicoll/spring-boot
that referenced
this pull request
Nov 18, 2024
Previously, the default Jackson2ObjectMapperBuilderCustomizer implementation did set the list of modules to use. This had the effect of removing any modules that were registered programmatically by a customizer with higher precedence. This commit uses the variant of modulesToInstall that retain any existing modules. It also adds a note in the documentation as this behavior can be easily missed. See spring-projectsgh-42836
snicoll
added a commit
to snicoll/spring-boot
that referenced
this pull request
Nov 18, 2024
|
This PR has been reviewed and is ready to go once we branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#39592