Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add throughput summary and fix timmer blocked by end=3 count=0 settings #346

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

Yangxulight
Copy link
Contributor

Here is what I did in this PR:

  1. Add Throughput summary when we call "/status" from a controller. (eventgen_controller_api.py)
  2. When we have a sample with settings of "count=0, end=3", the timer for that sample will blocked and only log "There is no data to be generated in worker...". because the execution is always 0. We should increase the execution so that this sample timer can finished the job after 3 execution.

@arctan5x
Copy link
Contributor

arctan5x commented Nov 8, 2019

Would you add a functional test for throughput summary?

@li-wu
Copy link
Contributor

li-wu commented Nov 9, 2019

Would you add a functional test for throughput summary?

+1. Especially for the end = 3 and count = 0 setting scenario. Thanks, Ryan.

@Yangxulight
Copy link
Contributor Author

It seems that the CircleCI was blocked by my test code(ec9192c). Do you guys have some ideas about the reason?

@li-wu
Copy link
Contributor

li-wu commented Dec 3, 2019

It seems that the CircleCI was blocked by my test code(ec9192c). Do you guys have some ideas about the reason?

Could you place the test logic in another test function since you need to set the conf and start eventgen and validate the logic?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants