Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: highlight underscores as code block #1493

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

soleksy-splunk
Copy link
Contributor

Issue number:
N/A

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Configuration for documentation lint.

Changes

Please provide a summary of the changes.
use asterisk as bold sign

User experience

Please describe the user experience before and after this change. Screenshots are welcome for additional context.
N/A

Checklist

If an item doesn't apply to your changes, leave it unchecked.

@soleksy-splunk soleksy-splunk requested a review from a team as a code owner November 28, 2024 10:41
docs/CHANGELOG.md Outdated Show resolved Hide resolved
# MD050/strong-style
MD050:
style: "asterisk"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the next time CI would just failed to deploy documentation from main and we will have to create a hotfix for main branch to fix formatting

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, true, let me remove it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, it is already failed. So, it does not matter for what reason it would fail..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, but even then it does not change anything, as this file is generated after main pipeline runs, so it will fail for both cases.

Maybe just worth ading it for other files? but for that one the pipeline will fail in PR, so also not a big benefit.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems fail only if the formatting is not consistent

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, that is the default option,

MD050:
  style: "consistent"

so there are 2 possibilities:

  1. we add this rule and it will fail when underscores( _ ) appears due to incorrect sign being used as bolder sign,
  2. we do not add it and it will fail when underscores( _ ) due to inconsistent bolder signs

Copy link
Contributor

@vtsvetkov-splunk vtsvetkov-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a bit correction to the PR title and LGTM

@soleksy-splunk soleksy-splunk changed the title docs: use asterisk as bolder docs: highlight underscores as code block Nov 28, 2024
@soleksy-splunk soleksy-splunk merged commit cc52c9e into develop Nov 28, 2024
98 checks passed
@soleksy-splunk soleksy-splunk deleted the docs/use-asterix-as-boldering-sign branch November 28, 2024 13:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants