Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(appinspect-api): make it pass #1491

Merged
merged 1 commit into from
Nov 27, 2024
Merged

chore(appinspect-api): make it pass #1491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/build-test-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,8 +325,7 @@ jobs:
needs: build-test-addon
if: |
!cancelled() &&
needs.build-test-addon.result == 'success' &&
( github.base_ref == 'main' || github.ref_name == 'main' )
needs.build-test-addon.result == 'success'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure what was limitation to run it only for main but we can go with main or develop also

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not to overload their service, no other reason

runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand Down
2 changes: 0 additions & 2 deletions ...data/expected_addons/expected_output_global_config_everything/.appinspect_api.expect.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +0,0 @@
check_for_compiled_python:
comment: 'Expected failure as compiled python file was detected in your build.'
2 changes: 1 addition & 1 deletion tests/testdata/test_addons/package_global_config_everything/package/app.manifest
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"commonInformationModels": null,
"license": {
"name": null,
"text": "LICENSES/Apache-2.0.txt",
"text": "LICENSES/Apache License 2.0.txt",
"uri": null
},
"privacyPolicy": {
Expand Down
Loading