Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow packaging from 23.0 #1484

Merged
merged 2 commits into from
Nov 26, 2024
Merged

fix: allow packaging from 23.0 #1484

merged 2 commits into from
Nov 26, 2024

Conversation

artemrys
Copy link
Member

Issue number: N/A

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Changes

Allow packaging from a version "23.0".

To reproduce the issue run

pip install splunk-add-on-ucc-framework==5.53.1
pip install splunk-appinspect==3.8.1

You should see

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
splunk-add-on-ucc-framework 5.53.1 requires packaging==24.0, but you have packaging 23.0 which is incompatible.

in your console.

User experience

Developers can install latest version of both UCC and Splunk AppInspect CLI in the same virtual environment.

Checklist

If an item doesn't apply to your changes, leave it unchecked.

@artemrys artemrys requested a review from a team as a code owner November 26, 2024 11:49
@artemrys artemrys enabled auto-merge (squash) November 26, 2024 12:43
@artemrys artemrys merged commit 29accc4 into develop Nov 26, 2024
97 checks passed
@artemrys artemrys deleted the wider-packaging-version branch November 26, 2024 13:02
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants