feat: add license during init command #1475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemrys
requested changes
Nov 24, 2024
artemrys
reviewed
Nov 25, 2024
tests/unit/test_main.py
Outdated
| [ | ||
| ( | ||
| { | ||
| "addon_name": "foo/bar", |
There was a problem hiding this comment.
That's an interesting test, should we allow foo/bar as an add-on name for the ucc-gen init command?
That's out of scope for this PR but worth checking our validations.
There was a problem hiding this comment.
Actually, we don't allow foo/bar as an addon-name, it's also mentioned in one of the unit test case
In the recent push I had changed the name to splunk_add_on_for_demo.
|
oopsie, tests are failing, @hetangmodi-crest please take a look. |
|
Fixed the smoke and umit test cases. |
artemrys
approved these changes
Nov 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: ADDON 76513
PR Type
What kind of change does this PR introduce?
Summary
Provided an optional flag (
--add-license) to generate a skeleton TA with predefined licenses.Changes
Introduced an optional
--add-licenseflag in theucc-gen initcommand. This flag allows you to include a license agreement file for popular licenses such asApache License 2.0,MIT License, orSPLUNK PRE-RELEASE SOFTWARE LICENSE AGREEMENTin theaddon_name/package/LICENSESfolder. If the input does not match one of these licenses, the add-on will fail to build.If the flag is not provided, an empty
License.txtfile will be created in theaddon_name/package/LICENSESdirectory for users.User experience
User can now add their licenses using the flag
--add-licenceswhile initializing the add-on.Checklist
If an item doesn't apply to your changes, leave it unchecked.