Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(TableWrapper): remove mocking immutability-helper dep #1471

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

vtsvetkov-splunk
Copy link
Contributor

@vtsvetkov-splunk vtsvetkov-splunk commented Nov 21, 2024

Issue number: -

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Changes

I stumbled to the issue this tests does not render updated values since update function was mocked. So, I am removing the mock to avoid confusions in future

User experience

No changes

Checklist

If an item doesn't apply to your changes, leave it unchecked.

@vtsvetkov-splunk vtsvetkov-splunk marked this pull request as ready for review November 21, 2024 11:41
@vtsvetkov-splunk vtsvetkov-splunk requested a review from a team as a code owner November 21, 2024 11:41
@vtsvetkov-splunk vtsvetkov-splunk enabled auto-merge (squash) November 21, 2024 11:41
@vtsvetkov-splunk vtsvetkov-splunk added the javascript Pull requests that update Javascript code label Nov 25, 2024
Signed-off-by: Viktor Tsvetkov <[email protected]>
@vtsvetkov-splunk vtsvetkov-splunk merged commit 69f7a5a into develop Nov 26, 2024
98 checks passed
@vtsvetkov-splunk vtsvetkov-splunk deleted the askudhasdkah branch November 26, 2024 13:20
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
javascript Pull requests that update Javascript code size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants