Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(SingleInputComponent): add expect and fix warning #1467

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

vtsvetkov-splunk
Copy link
Contributor

@vtsvetkov-splunk vtsvetkov-splunk commented Nov 19, 2024

Issue number:

PR Type

What kind of change does this PR introduce?

  • Feature
  • Bug Fix
  • Refactoring (no functional or API changes)
  • Documentation Update
  • Maintenance (dependency updates, CI, etc.)

Summary

Motivation

Every PR has this
image

but it is just a warning, so it does not fail the build

Changes

  • eslint considers this as an error instead of warning
  • fix the issue by adding explicit expects

User experience

No change

Checklist

If an item doesn't apply to your changes, leave it unchecked.

@vtsvetkov-splunk vtsvetkov-splunk requested a review from a team as a code owner November 19, 2024 14:50
@vtsvetkov-splunk vtsvetkov-splunk enabled auto-merge (squash) November 19, 2024 14:50
@vtsvetkov-splunk vtsvetkov-splunk merged commit 180c28d into develop Nov 20, 2024
98 checks passed
@vtsvetkov-splunk vtsvetkov-splunk deleted the feature/unittestswarning branch November 20, 2024 10:34
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants