Skip to content

Commit

Permalink
chore: update log statements
Browse files Browse the repository at this point in the history
  • Loading branch information
hetangmodi-crest committed Nov 28, 2024
1 parent d769db8 commit 62fc83e
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
7 changes: 4 additions & 3 deletions splunk_add_on_ucc_framework/tabs/proxy_tab.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ def updating_dictionaries(key_name: str, const: Any) -> None:
and definition.get("password") is False
):
logger.error(
"You had updated the username but set the password to 'false' which is not allowed "
"You have updated the username but set the password to 'false' which is not allowed "
"set `password = True` for default configuration."
)
sys.exit(1)
Expand All @@ -155,7 +155,7 @@ def updating_dictionaries(key_name: str, const: Any) -> None:
and definition.get("username") is False
):
logger.error(
"You had updated the password but set username to `false` which is not allowed "
"You have updated the password but set username to `false` which is not allowed "
"set `username = True` for default configuration."
)
sys.exit(1)
Expand All @@ -164,7 +164,8 @@ def updating_dictionaries(key_name: str, const: Any) -> None:
and type(definition.get("password")) is bool
):
logger.error(
"You had set conflicting values for username and password."
f"You have set different values for username ({definition.get('username')})"
f" and password ({definition.get('password')}). They should be same."
)
sys.exit(1)
for key_name, value in entity_key_const_dict.items():
Expand Down
6 changes: 3 additions & 3 deletions tests/unit/tabs/test_proxy_tab.py
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ def test_proxy_short_tab_has_default_parameters():
"password": {"label": "Password for Proxy"},
"username": False,
},
"You had updated the password but set username to `false` which is not allowed "
"You have updated the password but set username to `false` which is not allowed "
"set `username = True` for default configuration.",
),
(
Expand All @@ -122,7 +122,7 @@ def test_proxy_short_tab_has_default_parameters():
"username": {"label": "Username for Proxy"},
"password": False,
},
"You had updated the username but set the password to 'false' which is not allowed "
"You have updated the username but set the password to 'false' which is not allowed "
"set `password = True` for default configuration.",
),
(
Expand All @@ -132,7 +132,7 @@ def test_proxy_short_tab_has_default_parameters():
"username": True,
"password": False,
},
"You had set conflicting values for username and password.",
"You have set different values for username (True) and password (False). They should be same.",
),
],
)
Expand Down

0 comments on commit 62fc83e

Please sign in to comment.