Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sensitive index #20

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

gustawdaniel
Copy link
Contributor

fixed #13

@spence-s
Copy link
Owner

spence-s commented Mar 27, 2023

@gustawdaniel -- Ok I got it sorted with the build and stuff, feel free to change the eslint and prettier config the way you like most. -- If you don't mind fixing these PR's on what I have done, then I will merged in and bump npm versions.

in src/index.ts

please leave it exported as

export = DiffEngine

Which creates a simple default export for us that works well with TS in esm and cjs.

# Conflicts:
#	package-lock.json
#	src/diff/index.ts
#	src/index.ts
#	src/sentence/index.ts
#	test/sensitive-paths.test.ts
.prettierignore Outdated
@@ -0,0 +1 @@
README.md
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use prettier on readme?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it broke table probably by

  "printWidth": 120

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i removed README from this file and it seems to work now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how do you specify a path for any index in an array?
2 participants