Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix name of hello module in v3 getting-started doc #2003

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Fix name of hello module in v3 getting-started doc #2003

merged 1 commit into from
Nov 27, 2024

Conversation

chrisinmtown
Copy link
Contributor

@chrisinmtown chrisinmtown commented Nov 24, 2024 •
edited
Loading

Fixes #1948

@coveralls
Copy link

coveralls commented Nov 24, 2024 •
edited
Loading

Coverage Status

coverage: 94.408%. remained the same
when pulling ea0caad on chrisinmtown:1948-fix-v3-module-name
into cef665c on spec-first:main.

@chrisinmtown
Copy link
Contributor Author

Does someone have time to review this two-line change, please?

RobbeSneyders
RobbeSneyders approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@RobbeSneyders RobbeSneyders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @chrisinmtown

@RobbeSneyders RobbeSneyders merged commit 58c8bb6 into spec-first:main Nov 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobbeSneyders RobbeSneyders RobbeSneyders approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix module name in running the app instructions in v3.rst
3 participants
@chrisinmtown @coveralls @RobbeSneyders