Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from kill-all-exit to a normal exit when a child is done #51

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

puggan
Copy link
Contributor

@puggan puggan commented Dec 7, 2023

see #50

@puggan
Copy link
Contributor Author

puggan commented Dec 7, 2023

Found out how to reprocude it, and add an test for it.
90a6193

fails in the v1.2.1 and passes in this pr

@freekmurze freekmurze merged commit c79b4c1 into spatie:main Dec 7, 2023
6 checks passed
@freekmurze
Copy link
Member

Thanks!

@apibrain
Copy link

I found that using exit() here will lead 'mysql has gone away' problem (Even though I reconnect mysql at before child function) , and when I switch back to $this->exit(), all is fine.

I don't test other situations, so I was in doubt about which one is the correct way.

(Environment: PHP 8 + macosx 14)

see also:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants