Make ArrayBoundsChecker a whole-program analysis to fix a concurrency bug #1453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On second note, I made ArrayBoundsCheck run for all reachable methods, as a whole-program transformation. Maybe a config option should be added incase someone wants to run the transformation only on application classes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1354. It's caused by the fact that multiple running ArrayBoundsChecker transformations can run certain analyses (SimpleLocalDefs) on the same method, resulting into data being overwritten (in this case, the local.getNumber field). I suspect this happened, because the transformation was designed before (2000) Soot parallelized BodyTransformation's or even supported SceneTransformation's.
I'm not sure if I modified all the documentation correctly. GitHub pages still needs to be modified I think. Furthermore, I added a -w flag to the annot-arraybounds, since now its a whole-program transformation. As for the ui code (PhaseOptionsDialog) I didn't test it.
I've tested the transformation and it works in whole-program mode. Hope this is of any use.