Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for extraVolumes/extraVolumeMounts #583

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Add support for extraVolumes/extraVolumeMounts #583

merged 2 commits into from
Sep 9, 2024

Conversation

chunter0
Copy link
Contributor

@chunter0 chunter0 commented Sep 6, 2024 •
edited
Loading

Description

Support extraVolumes/extraVolumeMounts fields which can be passed in by the user from helm values.

painter:
  extraVolumes:
  - name: custom-credentials
    secret: 
      secretName: some-secret
  extraVolumeMounts:
  - name: custom-credentials
    mountPath: /some/dir

BOT NOTES:
resolves #582

@solo-changelog-bot
Copy link

Issues linked to changelog:
#582

ashleywang1
ashleywang1 approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@ashleywang1 ashleywang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests

@soloio-bulldozer soloio-bulldozer bot merged commit 43680a0 into main Sep 9, 2024
3 checks passed
@soloio-bulldozer soloio-bulldozer bot deleted the chunter/issue-582 branch September 9, 2024 18:39
tjons pushed a commit that referenced this pull request Sep 10, 2024
@chunter0 @tjons
Add support for extraVolumes/extraVolumeMounts (#583)
37bff11 
* Add support for `extraVolumes/extraVolumeMounts`

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-pritchard josh-pritchard josh-pritchard approved these changes

@ashleywang1 ashleywang1 ashleywang1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add extraVolumes/extraVolumeMounts
3 participants
@chunter0 @ashleywang1 @josh-pritchard