Adding scheme to readiness probe #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pseudonator <[email protected]>
|
Issues linked to changelog: |
puertomontt
reviewed
Dec 4, 2023
codegen/cmd_test.go
Outdated
| @@ -2520,6 +2520,79 @@ roleRef: | |||
| Entry("sidecar service port name with hyphen", "foo-bar"), | |||
| ) | |||
|
|
|||
| It("allows fields from other packages", func() { | |||
There was a problem hiding this comment.
not sure I understand this test
There was a problem hiding this comment.
had the wrong description. fixed !
Signed-off-by: pseudonator <[email protected]>
puertomontt
previously approved these changes
Dec 5, 2023
Signed-off-by: pseudonator <[email protected]>
puertomontt
approved these changes
Dec 6, 2023
jenshu
approved these changes
Dec 6, 2023
day0ops
added a commit
that referenced
this pull request
Dec 11, 2023
* Adding scheme to readiness probe Signed-off-by: pseudonator <[email protected]> * Fixed test description Signed-off-by: pseudonator <[email protected]> * Updated the changelog ver Signed-off-by: pseudonator <[email protected]> --------- Signed-off-by: pseudonator <[email protected]>
day0ops
added a commit
that referenced
this pull request
Dec 11, 2023
* Adding scheme to readiness probe Signed-off-by: pseudonator <[email protected]> * Fixed test description Signed-off-by: pseudonator <[email protected]> * Updated the changelog ver Signed-off-by: pseudonator <[email protected]> --------- Signed-off-by: pseudonator <[email protected]>
jenshu
pushed a commit
that referenced
this pull request
Dec 12, 2023
* Adding scheme to readiness probe (#522) * Adding scheme to readiness probe Signed-off-by: pseudonator <[email protected]> * Fixed test description Signed-off-by: pseudonator <[email protected]> * Updated the changelog ver Signed-off-by: pseudonator <[email protected]> --------- Signed-off-by: pseudonator <[email protected]> * Backporting #521 Signed-off-by: pseudonator <[email protected]> --------- Signed-off-by: pseudonator <[email protected]>
jenshu
pushed a commit
that referenced
this pull request
Dec 12, 2023
* Adding scheme to readiness probe (#522) * Adding scheme to readiness probe Signed-off-by: pseudonator <[email protected]> * Fixed test description Signed-off-by: pseudonator <[email protected]> * Updated the changelog ver Signed-off-by: pseudonator <[email protected]> --------- Signed-off-by: pseudonator <[email protected]> * Backporting #521 Signed-off-by: pseudonator <[email protected]> --------- Signed-off-by: pseudonator <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces scheme for readiness probe.
For fixing #521