Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadinessProbe does not allow for scheme #521

Open
day0ops opened this issue Dec 2, 2023 · 1 comment
Open

ReadinessProbe does not allow for scheme #521

day0ops opened this issue Dec 2, 2023 · 1 comment
Assignees

Comments

@day0ops
Copy link
Contributor

day0ops commented Dec 2, 2023

ReadinessProbe always defaults to HTTP and doesnt allow the overlay chart to override the value.

Currently this is required for health checks invoking on endpoints with downstream TLS.

@day0ops day0ops self-assigned this Dec 2, 2023
@day0ops
Copy link
Contributor Author

day0ops commented Dec 2, 2023

This is a required feature for solving https://github.com/solo-io/gloo-mesh-enterprise/issues/10255

day0ops added a commit that referenced this issue Dec 11, 2023
Signed-off-by: pseudonator <[email protected]>
day0ops added a commit that referenced this issue Dec 11, 2023
Signed-off-by: pseudonator <[email protected]>
jenshu pushed a commit that referenced this issue Dec 12, 2023
* Adding scheme to readiness probe (#522)

* Adding scheme to readiness probe

Signed-off-by: pseudonator <[email protected]>

* Fixed test description

Signed-off-by: pseudonator <[email protected]>

* Updated the changelog ver

Signed-off-by: pseudonator <[email protected]>

---------

Signed-off-by: pseudonator <[email protected]>

* Backporting #521

Signed-off-by: pseudonator <[email protected]>

---------

Signed-off-by: pseudonator <[email protected]>
jenshu pushed a commit that referenced this issue Dec 12, 2023
* Adding scheme to readiness probe (#522)

* Adding scheme to readiness probe

Signed-off-by: pseudonator <[email protected]>

* Fixed test description

Signed-off-by: pseudonator <[email protected]>

* Updated the changelog ver

Signed-off-by: pseudonator <[email protected]>

---------

Signed-off-by: pseudonator <[email protected]>

* Backporting #521

Signed-off-by: pseudonator <[email protected]>

---------

Signed-off-by: pseudonator <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant