Remove duplicated and older dependency bumps on generation #519
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added code to only generate the latest dependency bumps on release.
When following semantic versioning
v[MAJOR][.MINOR][.PATCH]
, we only get the latest bump in the list of dependency bumps. When not following semantic versioning, we display all bumps done within the release.Context
We've previously had instance on release, where we see multiple dependency bumps for the same dependency, for example:
In order to mitigate this, developers have to manually remove older reference bumps within the same release version - which is easy to forget.
Other possible path(s) forward
DEPENDENCY_BUMP
s in changelogs #510TODO / NOTES
gloo
to1.15.0
. On Tuesday we decide we want to downgrade to1.14.0-rc5
.1.15.0
on the release changelog, since it's the greater of both. BUT the downgrade was the latest and most important...patch
postfix on a tag, and then bump torc
?semver.Compare
just compares the postfixes as strings, sopatch
is a "newer" release than anrc
.These are probably not super likely scenarios, but still technically possible.