CI: Adds Ginkgo Resource Condition Assertions #10398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daneyon Hansen <[email protected]>
|
Issues linked to changelog: |
4 tasks
danehans
changed the title
|
Visit the preview URL for this PR (updated for commit ef580d7): https://gloo-edge--pr10398-issue-10397-gwsbfru2.web.app (expires Mon, 02 Dec 2024 16:33:25 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 77c2b86e287749579b7ff9cadb81e099042ef677 |
nfuden
reviewed
Nov 25, 2024
sam-heilbron
approved these changes
Nov 25, 2024
| @@ -19,7 +19,7 @@ import ( | |||
|
|
|||
| // MustKindContext returns the Context for a KinD cluster with the given name | |||
| func MustKindContext(clusterName string) *Context { | |||
| return MustKindContextWithScheme(clusterName, schemes.DefaultScheme()) | |||
| return MustKindContextWithScheme(clusterName, schemes.TestingScheme()) | |||
|
|
||
| err = s.testInstallation.Actions.Kubectl().ApplyFile(s.ctx, multiTcpRouteManifest) | ||
| s.Assert().NoError(err, "can apply tcproute manifest") | ||
| s.testInstallation.Assertions.EventuallyTCPRouteCondition(s.ctx, "tcp-app-1", "default", v1.RouteConditionAccepted, metav1.ConditionTrue, timeout) |
There was a problem hiding this comment.
nit: Do you think it would be valuable to assert on a list of conditions?
There was a problem hiding this comment.
I was considering ^ but I decided to start simple, mainly b/c we need to check the condition status for the different types, e.g. Accecpted=True while Conflicted=False.
|
/skip-ci only changing test/kubernetes/e2e and thus build-bot isn't relevant |
nfuden
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ginkgo assertions for resource status of TCPRoute e2e tests.
Fixes # 10397