Skip to content

Commit

Permalink
build: repair broken tests (#7872)
Browse files Browse the repository at this point in the history
  • Loading branch information
gunnar-solo authored Feb 22, 2023
1 parent 662fd1f commit 774a816
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions changelog/v1.11.53/host-repair.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
changelog:
- type: NON_USER_FACING
description: repaired broken tests that face external postman service.
4 changes: 2 additions & 2 deletions test/e2e/dynamic_forward_proxy_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ var _ = Describe("dynamic forward proxy", func() {
// simpler e2e test without transformation to validate basic behavior
It("should proxy http if dynamic forward proxy header provided on request", func() {
destEcho := `postman-echo.com`
expectedSubstr := `"host":"postman-echo.com"`
expectedSubstr := `"host": "postman-echo.com"`
testReq := testRequest(destEcho, func(r *http.Request) {
r.Header.Set("x-rewrite-me", destEcho)
})
Expand Down Expand Up @@ -178,7 +178,7 @@ var _ = Describe("dynamic forward proxy", func() {
// request using a transformation and use that to determine the upstream destination to route to
It("should proxy http", func() {
destEcho := `postman-echo.com`
expectedSubstr := `"host":"postman-echo.com"`
expectedSubstr := `"host": "postman-echo.com"`
testReq := testRequest(destEcho, nil)
Expect(testReq).Should(ContainSubstring(expectedSubstr))
})
Expand Down

0 comments on commit 774a816

Please sign in to comment.