mod: upgrade istio deps #41
Conversation
…-000000000000: invalid version: unknown revision 000000000000
| github.com/solo-io/skv2 v0.30.0 | ||
| istio.io/client-go v1.17.1 | ||
| istio.io/istio v0.0.0-20221208171804-952b2e8bc4b0 | ||
| github.com/solo-io/skv2 v0.36.3 |
There was a problem hiding this comment.
Let's check that this skv2 bump does break with gloo mesh enterprise. It shouldn't, but it's currently using 0.36.1: https://github.com/solo-io/gloo-mesh-enterprise/blob/main/go.mod#L95
There was a problem hiding this comment.
Good call, I'll open a PR in GME to import this, and prove that it works via CI
There was a problem hiding this comment.
I updated the PR body to include this detail, but I opened https://github.com/solo-io/gloo-mesh-enterprise/pull/14631 to demonstrate tthis can be pulled in. I'll try to get eyes on that PR
There was a problem hiding this comment.
CI is passing on that linked PR, so I would consider this check completd, but happy to perform more validation if neeeded
| @@ -1,75 +1,76 @@ | |||
| module github.com/solo-io/external-apis | |||
|
|
|||
| go 1.21 | |||
| go 1.21.5 | |||
There was a problem hiding this comment.
Will adding the patch version here effect the edge side? I know gloo-mesh-enterprise is using patches and golang will do patch version upgrades automatically with the new version manager shipped in 1.21.1, but I thought edge is still using 1.21 in the go.mod
There was a problem hiding this comment.
Edge Enterprise relies on the same patch version as GME: https://github.com/solo-io/solo-projects/blob/main/go.mod#L3 (1.21.5), so I think we're safe
Background
Update the dependencies of our external-apis repository
Context
How did I choose these versions?
I used the gloo-mesh-enterprise go.mod as the source of truth, and fast-forwarded the dependencies in this project to match
How does this impact Gloo Edge?
Gloo Edge Enterprise relies on a pinned version of external-apis which is not built off of the main branch.
We have some ongoing work to import gme into solo-projects. To do this correctly, we get the opportunity to align the dependencies in the project.
How is this tested in Gloo Edge?
https://github.com/solo-io/solo-projects/pull/5742: We can successfully remove the pinned version, and reconcile all imports.
How is this tested in Gloo Mesh Enterprise?
https://github.com/solo-io/gloo-mesh-enterprise/pull/14631
What version will we release this in?
There aren't technically breaking changes in this change set, so I'm inclined to release this as a patch release:
v0.2.6