1.27: Add base64url fallback to base64_decode (#330) #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add base64url * clean up cout * example of test failing without proposed change * add discrete callbacks for base64url * fallback on standard base64 for base64url decode * keep existing behavior without fallback
|
Issues linked to changelog: |
ashishb-solo
reviewed
May 9, 2024
| transformer.transform(headers, &headers, body, callbacks); | ||
| EXPECT_NE(std::string::npos, body.toString().find(expect_string)); | ||
| } | ||
|
|
There was a problem hiding this comment.
would it be possible to add a test where we test for equality of the base64-decode callback?
| @@ -66,7 +66,9 @@ class TransformerInstance { | |||
| nlohmann::json env(const inja::Arguments &args) const; | |||
| nlohmann::json cluster_metadata_callback(const inja::Arguments &args) const; | |||
| nlohmann::json base64_encode_callback(const inja::Arguments &args) const; | |||
| nlohmann::json base64url_encode_callback(const inja::Arguments &args) const; | |||
There was a problem hiding this comment.
can we also add a test for base64url_encode?
nfuden
commented
May 9, 2024
ashishb-solo
reviewed
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for base64url in transformations