eitanya/bump-release-1.27 #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbohanon
force-pushed
the
eitanya/bump-release-1.27
branch
from
9496018
to
7d1c97a
Compare
jbohanon
force-pushed
the
eitanya/bump-release-1.27
branch
from
3b1b3aa
to
f14b2e7
Compare
|
Issues linked to changelog: |
nfuden
reviewed
Sep 19, 2023
| @@ -0,0 +1,10 @@ | |||
| rm -rf \ | |||
There was a problem hiding this comment.
non-blocking given urgency. I propose in our follow up thread we also update our make targets to have some subsection of this
There was a problem hiding this comment.
I think they are all overwritten given our use of cp -f but I mainly added this to have for local dev. I also added the files to .gitignore but I think this still has value
nfuden
approved these changes
Sep 19, 2023
|
static analysis seems like something that will save us time in the long run as a required ci check much quicker than debugging and dealing with later in customer envs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we move our dependency on upstream Envoy up to 1.27.0. In doing this, we address a number of issues:
do_ci.shoverhauldistribution/targets to build binary in mirror fashion to upstreamcontrib/to suppress errorzstdusing upstream's tool to access built binaryPython Root issue
Cloudbuild requires a container be run as root for its setup, but the latest python dependency within bazel forbids running as root. The dependency can be set up with a boolean flag
ignore_root_user_errorto suppress this error, which was added to theWORKSPACEfile.Regex
TODO
Static analysis
Static analysis began to fail on issues that it previously hadn't with our dependencies. We have separated this into a separate action in cloudbuild and marked it as not required.