-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NH-91603: custom otlp metrics through otlp protocol #169
base: main
Are you sure you want to change the base?
Conversation
Thanks for noting the limitation/question @xuan-cao-swi! I'd like our custom distro to do both: take a dependency on the exporter so that it is installed by default (guess it's not yet part of Any thoughts on possible downside / risk if we went this way? |
Also, otlp trace exporter is not part of opentelemetry-ruby sdk. I don't think they will include any exporter in sdk; but metrics-sdk will be part of sdk eventually. We install opentelemetry-exporter-otlp and opentelemetry-exporter-otlp-metrics by default in lambda through layer build, but not in our agent gemspec. To have periodic reader by default, then we may discourage user to manually pull/export the metrics. If user use aggregation_temporality as |
Actually the PeriodicMetricReader is enabled by default: https://github.com/open-telemetry/opentelemetry-ruby/blob/opentelemetry-metrics-sdk/v0.4.0/metrics_sdk/lib/opentelemetry/sdk/metrics/configuration_patch.rb#L44 User have choice to decide the duration of exporting |
Gotcha, let's make the same change in our custom distro, which also means no need to special case this in the lambda layer build :) |
Description
Current limitation (need more clarification):
Test (if applicable)