Skip to content

Various dual finance changes, most importantly validation and preview… #1413

Various dual finance changes, most importantly validation and preview…

Various dual finance changes, most importantly validation and preview… #1413

Triggered via pull request August 20, 2023 22:37
Status Failure
Total duration 3m 3s
Artifacts

ci-main-tests.yml

on: pull_request
Matrix: Static Security Tests
All tests pass
0s
All tests pass
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 10 warnings
Run Tests: pages/dao/[symbol]/proposal/components/instructions/Dual/StakingOption.tsx#L89
Optional chain expressions can return undefined by design - using a non-null assertion is unsafe and wrong
Run Tests: pages/dao/[symbol]/proposal/components/instructions/Dual/StakingOption.tsx#L106
Optional chain expressions can return undefined by design - using a non-null assertion is unsafe and wrong
Run Tests: utils/instructions/Dual/index.ts#L506
'baseAmountAtoms' is assigned a value but never used
Run Tests: utils/instructions/Dual/index.ts#L854
'_issueAuthorityBump' is assigned a value but never used
Run Tests: VoteStakeRegistry/components/TokenBalance/LockPluginTokenBalanceCard.tsx#L222
React Hook useEffect has a missing dependency: 'setHasGovPower'. Either include it or remove the dependency array. If 'setHasGovPower' changes too often, find the parent component that defines it and wrap that definition in useCallback
Run Tests: components/TreasuryAccount/MangoModal.tsx#L44
React Hook useEffect has missing dependencies: 'account.extensions.transferAddress', 'mangoClient', and 'mangoGroup'. Either include them or remove the dependency array
Run Tests: components/TreasuryAccount/MangoModal.tsx#L44
React Hook useEffect has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked
Run Tests: components/TreasuryAccount/Trade.tsx#L344
React Hook useCallback has missing dependencies: 'anchorProvider', 'fmtUrlWithCluster', 'handleCreateProposal', 'mintAccount.account.decimals', 'router', 'tokenAccount.pubkey', and 'voteByCouncil'. Either include them or remove the dependency array
Run Tests: components/treasuryV2/WalletList/WalletListItem/AssetList/index.tsx#L172
React Hook useEffect has missing dependencies: 'realm.account.communityMint' and 'realm.account.config.councilMint'. Either include them or remove the dependency array
Run Tests: hooks/useMangoV4.tsx#L61
React Hook useEffect has missing dependencies: 'GROUP', 'connection', 'getClient', and 'wallet'. Either include them or remove the dependency array
Run Tests: hooks/useMangoV4.tsx#L61
React Hook useEffect has a complex expression in the dependency array. Extract it to a separate variable so it can be statically checked
Run Tests: hub/components/EditWalletRules/createTransaction.ts#L9
'BigNumber' is defined but never used
Run Tests: hub/components/EditWalletRules/createTransaction.ts#L14
'queryClient' is defined but never used
Run Tests: hub/components/NewWallet/NewWallet.tsx#L55
'fmtUrlWithCluster' is assigned a value but never used